[PropertyInfo] Fix interface handling in PhpStanTypeHelper
#59012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, this fix seems to be valid even for 6.4, should I rebase? |
src/Symfony/Component/PropertyInfo/Tests/Extractor/PhpStanExtractorTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/PropertyInfo/Tests/Extractor/PhpStanExtractorTest.php
Outdated
Show resolved
Hide resolved
PhpStanTypeHelper
Will do that once this is approved. |
nicolas-grekas
approved these changes
Nov 28, 2024
mtarld
approved these changes
Dec 3, 2024
|
@janedbal Can you open the PR targeting 6.4? |
|
@xabbuh Sure, but it does not affect mergeability here, right? |
|
@janedbal, the 6.4 changes will be upmerged up to 7.3, therefore this 7.1 PR will become useless. |
|
Looks like we misunderstood each other, so I just rebase it to 6.4. No need for another MR, right? |
|
If there is not much difference between the branches, rebasing the PR on 6.4 should be enough. Having a different PR for 7.1 would only be useful if there are conflicts to be expected when merging up which would then serve as a reference for us to ease resolving the conflicts. |
a56d730 to
36f4d3f
Compare
|
Rebased and changed base branch to |
|
Is this mergeable now? Or are we waiting for code-owner approve? Or? |
chalasr
approved these changes
Dec 10, 2024
36f4d3f to
88e7a72
Compare
|
Thank you @janedbal. |
mtarld
added a commit
to mtarld/symfony
that referenced
this pull request
Dec 10, 2024
|
Thank you! |
fabpot
pushed a commit
to mtarld/symfony
that referenced
this pull request
Dec 11, 2024
fabpot
added a commit
that referenced
this pull request
Dec 11, 2024
…Helper (mtarld) This PR was merged into the 7.1 branch. Discussion ---------- [PropertyInfo] [7.1] Fix interface handling in PhpStanTypeHelper | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT Upmerge #59012 up to 7.1 Commits ------- 65b370e [PropertyInfo] Upmerge #59012
xabbuh
added a commit
that referenced
this pull request
Dec 11, 2024
* 7.1: Fix resolve enum in string type resolver [PropertyInfo] Upmerge #59012 [BeanstalkMessenger] Round delay to an integer to avoid deprecation warning [PropertyInfo] Fix interface handling in `PhpStanTypeHelper` [HttpClient] Test POST to GET redirects [HttpKernel] Denormalize request data using the csv format when using "#[MapQueryString]" or "#[MapRequestPayload]" (except for content data) fix: preserve and nowrap in profiler code highlighting
xabbuh
added a commit
that referenced
this pull request
Dec 11, 2024
* 7.2: Bump Symfony version to 7.2.2 Fix resolve enum in string type resolver Update VERSION for 7.2.1 Update CHANGELOG for 7.2.1 [PropertyInfo] Upmerge #59012 [BeanstalkMessenger] Round delay to an integer to avoid deprecation warning [Console] Fix tests [PropertyInfo] Fix interface handling in `PhpStanTypeHelper` [TypeInfo] Remove useless dependency [HttpClient] Test POST to GET redirects [TypeInfo] Fix outdated README [HttpKernel] Denormalize request data using the csv format when using "#[MapQueryString]" or "#[MapRequestPayload]" (except for content data) [TypeInfo] Fix handle nullable with mixed fix: preserve and nowrap in profiler code highlighting
This was referenced Dec 31, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, deserializing object with
Interface<T>property was failing on undefined array key inPhpStanTypeHelper(genericClazz<T>works just fine):