[VarDumper] Add caster for Socket instances #59026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Nov 28, 2024
•
| Q | A |
|---|---|
| Branch? | 7.3 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Issues | - |
| License | MIT |
stof
reviewed
Nov 28, 2024
ab4f85e to
3232f55
Compare
|
While working on other casters, this is the solution I came up with |
|
I can close here :) |
|
or we can merge and improve in a follow up |
|
Let's get this one merged and iterate over it 👍 |
stof
approved these changes
Nov 28, 2024
alexandre-daubois
approved these changes
Nov 29, 2024
stof
reviewed
Nov 29, 2024
| /** | ||
| * @author Nicolas Grekas <p@tchwork.com> | ||
| */ | ||
| final class SocketCaster |
There was a problem hiding this comment.
I suggest tagging it as @internal as it is an internal implementation detail of AbstractCloner.
|
Thank you @nicolas-grekas. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 9, 2025
… (alexandre-daubois)
This PR was squashed before being merged into the 7.3 branch.
Discussion
----------
[VarDumper] Add casters for object-converted resources
| Q | A
| ------------- | ---
| Branch? | 7.3
| Bug fix? | no
| New feature? | yes
| Deprecations? | yes
| Issues | -
| License | MIT
This PR makes up for the backlog of resources transformed into objects in the latest versions of PHP.
✅ Support added (or already existing with an update in `AbstractCloner`):
- ext-curl
- `CurlMultiHandle`: **no information to gather**
- ext-openssl
- `OpenSSLCertificateSigningRequest`
- `OpenSSLAsymmetricKey`
- ext-finfo
- **No information to gather**
- ext-sqlite3
- `Sqlite3Result`
- ext-sockets
- `Sockets` (to rebase on #59026)
- ext-pgsql
- `PgSql\Lob`
- `PgSql\Connection`
- `PgSql\Result`
⚠️ Remaining classes I couldn't test/find enough info yet (introduced in PHP 8.4):
- `Odbc\Connection`
- `Odbc\Result`
- `Soap\Url`
- `Soap\Sdl`
Commits
-------
7be6483 [VarDumper] Add casters for object-converted resources
symfony-splitter
pushed a commit
to symfony/var-dumper
that referenced
this pull request
Jan 9, 2025
… (alexandre-daubois)
This PR was squashed before being merged into the 7.3 branch.
Discussion
----------
[VarDumper] Add casters for object-converted resources
| Q | A
| ------------- | ---
| Branch? | 7.3
| Bug fix? | no
| New feature? | yes
| Deprecations? | yes
| Issues | -
| License | MIT
This PR makes up for the backlog of resources transformed into objects in the latest versions of PHP.
✅ Support added (or already existing with an update in `AbstractCloner`):
- ext-curl
- `CurlMultiHandle`: **no information to gather**
- ext-openssl
- `OpenSSLCertificateSigningRequest`
- `OpenSSLAsymmetricKey`
- ext-finfo
- **No information to gather**
- ext-sqlite3
- `Sqlite3Result`
- ext-sockets
- `Sockets` (to rebase on symfony/symfony#59026)
- ext-pgsql
- `PgSql\Lob`
- `PgSql\Connection`
- `PgSql\Result`
⚠️ Remaining classes I couldn't test/find enough info yet (introduced in PHP 8.4):
- `Odbc\Connection`
- `Odbc\Result`
- `Soap\Url`
- `Soap\Sdl`
Commits
-------
7be64835c4b [VarDumper] Add casters for object-converted resources
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.