[HttpClient] Fix Undefined array key "connection" #59044
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… default domain node visitor (xabbuh) This PR was merged into the 7.2 branch. Discussion ---------- [TwigBridge] use reproducible variable names in the default domain node visitor | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | Fix symfony#57609 (comment) | License | MIT Commits ------- 500d72f use reproducible variable names in the default domain node visitor
* 5.4: [DoctrineBridge] Backport symfony#53681
* 6.4: [DoctrineBridge] Backport symfony#53681
* 7.1: [DoctrineBridge] Backport symfony#53681
…nvalid characters
…RIs that contain invalid characters (nicolas-grekas) This PR was merged into the 7.2 branch. Discussion ---------- [DependencyInjection][HttpClient][Routing] Reject URIs that contain invalid characters | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT The behavior of `parse_url()` doesn't match how browsers parse URLs. This PR ensures we won't accept URLs that are invalid per https://url.spec.whatwg.org/: - URLs that contain a backslash - or start/end with a control-char or a space - or contain a CR/LF/TAB character Commits ------- d73003e [DependencyInjection][Routing][HttpClient] Reject URIs that contain invalid characters
* 5.4: [Runtime] fix tests
* 6.4: [Runtime] fix tests
* 7.1: [HttpFoundation] Fix merge [Runtime] fix tests
* 5.4: [Process] Fix test
* 6.4: [Process] Fix test
* 7.1: [Process] Fix test
released v6.4.14
released v7.1.7
released v7.2.0-BETA2
* 5.4: Port Appveyor to GitHub Actions normalize paths to avoid failures if a path is referenced by different names skip autocomplete test when stty is not available Bump Symfony version to 5.4.47 Update VERSION for 5.4.46 Update CONTRIBUTORS for 5.4.46 Update CHANGELOG for 5.4.46
* 6.4: Port Appveyor to GitHub Actions normalize paths to avoid failures if a path is referenced by different names skip autocomplete test when stty is not available Bump Symfony version to 6.4.15 Update VERSION for 6.4.14 Update CHANGELOG for 6.4.14 Bump Symfony version to 5.4.47 Update VERSION for 5.4.46 Update CONTRIBUTORS for 5.4.46 Update CHANGELOG for 5.4.46
released v7.1.9
* 5.4: [HttpClient] Fix streaming and redirecting with NoPrivateNetworkHttpClient Bump Symfony version to 5.4.49 Update VERSION for 5.4.48 Update CONTRIBUTORS for 5.4.48 Update CHANGELOG for 5.4.48
* 6.4: [HttpClient] Fix streaming and redirecting with NoPrivateNetworkHttpClient Bump Symfony version to 6.4.17 Update VERSION for 6.4.16 Update CHANGELOG for 6.4.16 Bump Symfony version to 5.4.49 Update VERSION for 5.4.48 Update CONTRIBUTORS for 5.4.48 Update CHANGELOG for 5.4.48
* 7.1: [HttpClient] Fix streaming and redirecting with NoPrivateNetworkHttpClient Bump Symfony version to 7.1.10 Update VERSION for 7.1.9 Update CHANGELOG for 7.1.9 Bump Symfony version to 6.4.17 Update VERSION for 6.4.16 Update CHANGELOG for 6.4.16 Bump Symfony version to 5.4.49 Update VERSION for 5.4.48 Update CONTRIBUTORS for 5.4.48 Update CHANGELOG for 5.4.48
released v7.2.0
Signed-off-by: Phil E. Taylor <phil@phil-taylor.com>
8706b38 to
6f28b1c
Compare
|
Must target against 5.4 or backport - original PR was against 5.4. |
|
ah crap, changing the base screwed the PR :) Fridays suck. I suck. Will redo. |
PhilETaylor
added a commit
to PhilETaylor/symfony
that referenced
this pull request
Nov 29, 2024
Signed-off-by: Phil E. Taylor <phil@phil-taylor.com>
|
5.4 based replacement here #59046 |
nicolas-grekas
pushed a commit
to PhilETaylor/symfony
that referenced
this pull request
Jan 8, 2025
Signed-off-by: Phil E. Taylor <phil@phil-taylor.com>
nicolas-grekas
added a commit
that referenced
this pull request
Jan 8, 2025
…ylor) This PR was submitted for the 5.4 branch but it was merged into the 6.4 branch instead. Discussion ---------- [HttpClient] Fix Undefined array key `connection` | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Issues | Fix #59039 <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT Check for array key before attempting to access it Code style for human reading Commits ------- 51c32ef [HttpClient] Fix Undefined array key "connection" #59044
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for array key before attempting to access it
Code style for human reading