[Messenger] ensure exception on rollback does not hide previous exception #59103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
approved these changes
Dec 6, 2024
1590dbd to
b58d49a
Compare
b58d49a to
0817d62
Compare
|
The changes done in Doctrine are slightly different, is it on purpose? |
ro0NL
reviewed
Dec 18, 2024
src/Symfony/Bridge/Doctrine/Messenger/DoctrineTransactionMiddleware.php
Outdated
Show resolved
Hide resolved
c8726c3 to
0c7ece5
Compare
0c7ece5 to
f38d4b0
Compare
fabpot
approved these changes
Dec 18, 2024
chalasr
approved these changes
Dec 18, 2024
|
Thank you @nikophil. |
This was referenced Dec 31, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this is kinda related to doctrine/orm#11230 and doctrine/orm#11646
I propose to use the same logic in
DoctrineTransactionMiddlewarethan in doctrine/orm#11646 towards rollback: currently if an error occurs in the rollback (for example, the infamousSAVEPOINT DOCTRINE_2 does not exist), the previous error is hidden, because the error should not occur in thecatch.ping @ro0NL
EDIt: failure in CI is unrelated to this PR