[BeanstalkMessenger] Round delay to an integer to avoid deprecation warning #59160
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
| @@ -123,7 +123,7 @@ public function send(string $body, array $headers, int $delay = 0): string | |||
| $job = $this->client->useTube($this->tube)->put( | |||
| $message, | |||
| PheanstalkInterface::DEFAULT_PRIORITY, | |||
| $delay / 1000, | |||
| (int) round($delay / 1000), | |||
There was a problem hiding this comment.
Why use round()?
| (int) round($delay / 1000), | |
| (int) ($delay / 1000), |
There was a problem hiding this comment.
@fabpot Using (int) round($delay / 1000) ensures that the delay value is properly rounded to the nearest integer before being passed to Pheanstalk::put(). While suggested truncation may work, I'd rather use rounding to be more accurate when converting from milliseconds to seconds.
There was a problem hiding this comment.
@fabpot oh, I see it now. Adding round() will change current behaviour. Implicit conversion converts float 0.9 to a zero int.
ea6bb12 to
99aae50
Compare
|
Thank you @plantas. |
https://github.com/pheanstalk/pheanstalk/blob/1459f2f62dddfe28902e0584708417dddd79bd70/src/Pheanstalk.php#L223-L228
The
Pheanstalk::put()method expects the$delayparameter to be an integer. However, during the conversion from milliseconds to seconds, it is passed as a float. This triggers a deprecation warning: 'Deprecated: Implicit conversion from float to int loses precision.'