Skip to content

[FrameworkBundle] Fix symfony/translation conflict #59176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

alexandre-daubois
Copy link
Member

Q A
Branch? 7.3
Bug fix? yes
New feature? no
Deprecations? no
Issues -
License MIT

Fix failing translator test in FWB for low-deps. A fix to support both nikic/php-parser 4 and 5 was introduced in 6.4.3, thus the conflict being updated.

The error being fixed is https://github.com/symfony/symfony/actions/runs/12278002300/job/34258706124#step:9:7177.

@xabbuh
Copy link
Member

xabbuh commented Dec 12, 2024

Thank you @alexandre-daubois.

@xabbuh xabbuh merged commit ea31908 into symfony:7.3 Dec 12, 2024
4 of 11 checks passed
@alexislefebvre
Copy link
Contributor

Fix failing translator test in FWB for low-deps. A fix to support both nikic/php-parser 4 and 5 was introduced in 6.4.3, thus the conflict being updated.

This PR targeted 7.3, should it have targeted 6.4 instead?

The conflict hasn't been changed on 6.4: https://github.com/alexandre-daubois/symfony/blob/4b2ebd9ab4f870c6c26e54a3ea662290b7cc5944/src/Symfony/Bundle/FrameworkBundle/composer.json#L101

@alexandre-daubois
Copy link
Member Author

7.3 is the only branch affected by the issue, thus this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants