Skip to content

[FrameworkBundle] do not allow symfony/json-encoder 7.4 yet #59180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Dec 11, 2024

Q A
Branch? 7.3
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

The component is experimental. Claiming to be compatible with 7.4 could lead to having to change a stable 7.3 release of the FrameworkBundle if the JsonEncoder component introduced BC breaks in 7.4.

Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done remembering of this 👍 ref #57630 (comment)

@stof
Copy link
Member

stof commented Dec 11, 2024

Doing that only in a dev requirement does not fully solve the issue though, as it applies only to our CI.

Copy link
Member

@alexandre-daubois alexandre-daubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes indeed, thanks!

@xabbuh
Copy link
Member Author

xabbuh commented Dec 12, 2024

@stof conflict rule added

The component is experimental. Claiming to be compatible with 7.4 could
lead to having to change a stable 7.3 release of the FrameworkBundle if
the JsonEncoder component introduced BC breaks in 7.4.
@fabpot
Copy link
Member

fabpot commented Dec 14, 2024

Thank you @xabbuh.

@fabpot fabpot merged commit 95c43e3 into symfony:7.3 Dec 14, 2024
9 of 11 checks passed
@xabbuh xabbuh deleted the pr-59174 branch December 14, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants