Skip to content

[PropertyInfo] Add non-*-int missing types for PhpStanExtractor #59192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2024
Merged

[PropertyInfo] Add non-*-int missing types for PhpStanExtractor #59192

merged 1 commit into from
Dec 18, 2024

Conversation

wuchen90
Copy link
Contributor

@wuchen90 wuchen90 commented Dec 12, 2024 •
edited by nicolas-grekas
Loading

Q A
Branch? 7.3
Bug fix? no
New feature? yes
Deprecations? no
License MIT

This PR adds support for following PHPStan types in Property Info component:

  • non-positive-int
  • non-negative-int
  • non-zero-int

See PHPStan official docs for these types: https://phpstan.org/writing-php-code/phpdoc-types#integer-ranges

@wuchen90 wuchen90 requested a review from dunglas as a code owner December 12, 2024 08:27
@carsonbot carsonbot added this to the 6.4 milestone Dec 12, 2024
@fabpot
Copy link
Member

fabpot commented Dec 16, 2024

I'm going to merge it in 7.3 as this is a new feature.

@fabpot fabpot modified the milestones: 6.4, 7.3 Dec 16, 2024
@nicolas-grekas
Copy link
Member

@wuchen90 to match @fabpot's comment, could you please rebase on 7.3 and add a line in the changelog of the component in the 7.3 section? (to be created potentially)

@derrabus derrabus changed the base branch from 6.4 to 7.3 December 16, 2024 10:44
@derrabus
Copy link
Member

Also, please rebase onto 7.3 and resolve the conflicts.

@xabbuh xabbuh added Feature and removed Bug labels Dec 16, 2024
@wuchen90 wuchen90 force-pushed the fix-phpstan-non-int branch 3 times, most recently from a08658d to 82904ae Compare December 16, 2024 16:39
xabbuh
xabbuh approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with a minor CS change in the changelog

@wuchen90 wuchen90 force-pushed the fix-phpstan-non-int branch from 4a1ea0c to 761bb04 Compare December 17, 2024 12:08
@fabpot
Copy link
Member

fabpot commented Dec 18, 2024

Thank you @wuchen90.

@fabpot fabpot merged commit ccf91a1 into symfony:7.3 Dec 18, 2024
11 checks passed
@fabpot fabpot mentioned this pull request Dec 18, 2024
Closed
@wuchen90 wuchen90 deleted the fix-phpstan-non-int branch January 20, 2025 09:32
@fabpot fabpot mentioned this pull request May 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@stof stof stof approved these changes

@derrabus derrabus derrabus approved these changes

@xabbuh xabbuh xabbuh approved these changes

@mtarld mtarld mtarld approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Feature PropertyInfo Status: Reviewed
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.
8 participants
@wuchen90 @fabpot @nicolas-grekas @derrabus @stof @xabbuh @mtarld @carsonbot