[Semaphore] Add a semaphore store based on locks #59202
Open
+182
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6921d4f to
38cb65b
Compare
jderusse
reviewed
Dec 12, 2024
1fef9d7 to
84e0607
Compare
…aseLocks correctly on failing semphore acquired
stof
reviewed
Jan 8, 2025
|
@jderusse if you have some free time maybe you can have a relook at the changes we did since your last review as you are I think most familiar with semaphore component. |
|
@jderusse what I'm stuck of how we can make the framework bundle integration for this. |
OskarStark
reviewed
Apr 30, 2025
| @@ -24,7 +24,8 @@ | |||
| "psr/log": "^1|^2|^3" | |||
| }, | |||
| "require-dev": { | |||
| "predis/predis": "^1.1|^2.0" | |||
| "predis/predis": "^1.1|^2.0", | |||
| "symfony/lock": "^5.4 || ^6.0 || ^7.0" | |||
There was a problem hiding this comment.
do we really want to allow those old versions here?
|
I really like this proposal! Is @jderusse's feedback to #59202 (comment) the only blocker? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really liked the idea of a semaphore component but not have the possibility to use it without Redis it did not get a lot a drive and usage in our projects and we workaround using Locks.
So this idea did come up to have a Semaphore store which can use the existing lock component for it.
@lyrixx @jderusse