[Notifier] unsupported options exception #59234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, you need to raise the minimum |
OskarStark
approved these changes
Dec 17, 2024
0a5d2c9 to
a8ca2d6
Compare
|
@OskarStark like this ? 🤔 |
xabbuh
reviewed
Dec 17, 2024
src/Symfony/Component/Notifier/Exception/UnsupportedOptionsException.php
Outdated
Show resolved
Hide resolved
|
maybe we should also add the type that was actually passed as part of the exception message |
|
I did it at first, inspired by the \Symfony\Component\Notifier\Exception\UnsupportedMessageTypeException and then I saw that all the existing exception had the same format so I reused it. |
|
@xabbuh Done ✅ (reused the format of the \Symfony\Component\Notifier\Exception\UnsupportedMessageTypeException) |
xabbuh
reviewed
Dec 17, 2024
src/Symfony/Component/Notifier/Exception/UnsupportedOptionsException.php
Outdated
Show resolved
Hide resolved
fabpot
approved these changes
Dec 18, 2024
e496f5f to
27dfb8c
Compare
|
Thank you @raphael-geffroy. |
|
Thanks to you @OskarStark @xabbuh @fabpot 🫶 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streamline one more exception for the bridges regarding option classes.