Skip to content

[Stopwatch] fix an undefined key error when trying to fetch a missing section #59251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 94 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
94 commits
Select commit Hold shift + click to select a range
bec056a
Bump version to 7.3
fabpot Nov 20, 2024
f194b1b
Merge branch '7.2' into 7.3
nicolas-grekas Nov 20, 2024
40f55d7
Merge branch '7.2' into 7.3
xabbuh Nov 20, 2024
0f5e3f4
Merge branch '7.2' into 7.3
xabbuh Nov 20, 2024
9fac435
chore: fix some typos
wanxiangchwng Nov 23, 2024
5a90414
minor #58972 chore: fix some typos (wanxiangchwng)
fabpot Nov 23, 2024
4786a74
Merge branch '7.2' into 7.3
nicolas-grekas Nov 25, 2024
e5fe662
Merge branch '7.2' into 7.3
nicolas-grekas Nov 25, 2024
d867b12
Merge branch '7.2' into 7.3
xabbuh Nov 26, 2024
3feb53b
Merge branch '7.2' into 7.3
nicolas-grekas Nov 27, 2024
6f8f122
Merge branch '7.2' into 7.3
nicolas-grekas Nov 27, 2024
5ce5528
Merge branch '7.2' into 7.3
nicolas-grekas Nov 27, 2024
136bde3
Merge branch '7.2' into 7.3
nicolas-grekas Nov 27, 2024
9d85c55
[VarDumper] Add caster for AddressInfo objects
nicolas-grekas Nov 26, 2024
baf98b9
feature #58989 [VarDumper] Add caster for `AddressInfo` objects (nico…
nicolas-grekas Nov 28, 2024
3232f55
[VarDumper] Add caster for Socket instances
nicolas-grekas Nov 28, 2024
4ed9d03
Merge branch '7.2' into 7.3
nicolas-grekas Nov 29, 2024
4feeb98
Merge branch '7.2' into 7.3
xabbuh Dec 2, 2024
73d4904
Merge branch '7.2' into 7.3
xabbuh Dec 2, 2024
aed69bb
[JsonEncoder] Introduce component
mtarld Mar 20, 2023
9c59199
Add webhooks signature verification on Sweego bridges
welcoMattic Oct 24, 2024
2d1838a
feature #59026 [VarDumper] Add caster for Socket instances (nicolas-g…
fabpot Dec 6, 2024
3a804f5
feature #58651 [Mailer][Notifier] Add webhooks signature verification…
fabpot Dec 6, 2024
5fa3e92
[AssetMapper] add support for assets pre-compression
dunglas Nov 27, 2024
12e4e53
feature #59020 [AssetMapper] add support for assets pre-compression (…
fabpot Dec 6, 2024
99737f9
[AssetMapper] Fix missing return type
alexandre-daubois Dec 6, 2024
36cb3bf
Move properties above `__construct()` method
OskarStark Dec 6, 2024
a61bd89
Rename TranslationUpdateCommand to TranslationExtract command to matc…
welcoMattic Dec 6, 2024
b6d6adf
minor #59105 [FrameworkBundle] Rename TranslationUpdateCommand to Tra…
fabpot Dec 7, 2024
0d28cf1
minor #59112 [Scheduler] Move properties above `__construct()` method…
fabpot Dec 7, 2024
41dacf7
Add @return non-empty-string annotations to AbstractUid and relevant …
niravpateljoin Dec 3, 2024
01c78b3
support non-empty-string/non-empty-list when patching return types
xabbuh Dec 7, 2024
b6c7abc
Merge branch '7.2' into 7.3
xabbuh Dec 7, 2024
c98b02a
Merge branch '7.2' into 7.3
derrabus Dec 7, 2024
b7ed0a4
feature #59114 [ErrorHandler] support non-empty-string/non-empty-list…
derrabus Dec 7, 2024
12ff1bf
feature #59075 [Uid] Add ``@return` non-empty-string` annotations to …
derrabus Dec 7, 2024
5c7dac2
minor #59108 [AssetMapper] Fix missing return type (alexandre-daubois)
derrabus Dec 7, 2024
096bfaa
[Security][SecurityBundle] User authorization checker
Dec 13, 2021
4612ff2
feature #48142 [Security][SecurityBundle] User authorization checker …
derrabus Dec 7, 2024
b6597b6
[AssetMapper] minor fixes for pre-compression
dunglas Dec 7, 2024
a185129
Remove ServiceSubscriberInterface implementation
derrabus Dec 7, 2024
0a44b87
bug #59130 [AssetMapper] minor fixes for pre-compression (dunglas)
fabpot Dec 9, 2024
8b271eb
Merge branch '7.2' into 7.3
xabbuh Dec 9, 2024
8c841e3
minor #59133 Remove ServiceSubscriberInterface implementation from Se…
fabpot Dec 9, 2024
6d3c219
[Workflow] Update union to intersection for mock type
alexandre-daubois Dec 10, 2024
eac7d49
[Console] Add support of millisecondes for `formatTime`
SebLevDev Nov 20, 2024
d1a3375
feature #58946 [Console] Add support of millisecondes for `formatTime…
fabpot Dec 10, 2024
7e4178a
[HttpFoundation] Support iterable of string in `StreamedResponse`
mtarld Dec 10, 2024
049bc63
[Console] Fix time display in tests
alexandre-daubois Dec 10, 2024
57c8040
minor #59158 [Console] Fix time display in tests (alexandre-daubois)
fabpot Dec 10, 2024
c198130
feature #51718 [Serializer] [JsonEncoder] Introducing the component (…
fabpot Dec 10, 2024
cfe09c2
feature #59154 [HttpFoundation] Support iterable of string in `Stream…
fabpot Dec 10, 2024
ac1f54c
[HttpKernel] [MapQueryString] added key argument to MapQueryString at…
feymo Dec 10, 2024
bb8fc43
feature #59157 [HttpKernel] [MapQueryString] added key argument to Ma…
fabpot Dec 10, 2024
edf5830
[JsonEncoder] Fix timezone on `DateTimeNormalizerTest` fixture
alexandre-daubois Dec 10, 2024
2d54786
minor #59162 [JsonEncoder] Fix timezone on `DateTimeNormalizerTest` f…
chalasr Dec 10, 2024
e213884
[FrameworkBundle] [JsonEncoder] Wire services
mtarld Oct 9, 2024
a6f4524
[JsonEncoder] remove some unnecessary recomputations in LazyInstantiator
jdreesen Dec 10, 2024
3ffb4fc
minor #59164 [JsonEncoder] remove some unnecessary recomputations in …
fabpot Dec 11, 2024
cd84496
minor #59151 [Workflow] Fix union to intersection for mock type (alex…
fabpot Dec 11, 2024
30d8c31
feature #58515 [FrameworkBundle][JsonEncoder] Wire services (mtarld)
chalasr Dec 11, 2024
7082e2e
[FrameworkBundle] Fix `JsonEncoder` config on low-deps
alexandre-daubois Dec 11, 2024
981c3a2
minor #59174 [FrameworkBundle] Add `symfony/json-encoder` to dev requ…
chalasr Dec 11, 2024
4ababf2
Merge branch '7.2' into 7.3
xabbuh Dec 11, 2024
0d74921
[JsonEncoder] [FrameworkBundle] Fix service definition
mtarld Dec 11, 2024
ffccbc3
[JsonEncoder] Add native lazyghost support
mtarld Dec 11, 2024
7369408
[FrameworkBundle] Fix `symfony/translation` conflict
alexandre-daubois Dec 11, 2024
92ef8bc
chore: PHP CS Fixer fixes
keradus Dec 11, 2024
64e6b78
minor #59173 chore: PHP CS Fixer fixes (keradus)
fabpot Dec 12, 2024
01956e2
Merge branch '7.2' into 7.3
xabbuh Dec 12, 2024
7162f0f
fix NativeTransportFactoryTest
xabbuh Dec 12, 2024
31c4198
minor #59195 [Mailer] fix NativeTransportFactoryTest (xabbuh)
xabbuh Dec 12, 2024
ea31908
minor #59176 [FrameworkBundle] Fix `symfony/translation` conflict (al…
xabbuh Dec 12, 2024
aa23093
minor #59179 [FrameworkBundle] [JsonEncoder] Fix service definition …
xabbuh Dec 12, 2024
c2c0e8b
do not allow symfony/json-encoder 7.4 yet
xabbuh Dec 11, 2024
0e83e1e
[JsonEncoder] Use reuse decodeString in NativeDecoder
alamirault Dec 12, 2024
d57efd1
minor #59203 [JsonEncoder] Reuse decodeString in NativeDecoder (alami…
chalasr Dec 13, 2024
a533750
Generate url-safe signatures
valtzu Nov 27, 2024
49c622f
chore: PHP CS Fixer fixes
keradus Dec 13, 2024
812c533
minor #59210 chore: PHP CS Fixer fixes (keradus)
fabpot Dec 14, 2024
95c43e3
minor #59180 [FrameworkBundle] do not allow symfony/json-encoder 7.4 …
fabpot Dec 14, 2024
278d62c
rename userIsGranted() to isGrantedForUser()
xabbuh Dec 15, 2024
3d807c1
[Routing] Validate "namespace" (when using `Psr4DirectoryLoader`)
Kocal Dec 11, 2024
30b8038
minor #59189 [Routing] Validate "namespace" (when using `Psr4Director…
fabpot Dec 16, 2024
dd882db
minor #59214 [Security][SecurityBundle] rename userIsGranted() to isG…
fabpot Dec 16, 2024
761bb04
[PropertyInfo] Add non-*-int missing types for PhpStanExtractor
wuchen90 Dec 12, 2024
27dfb8c
[Notifier] unsupported options exception
raphael-geffroy Dec 17, 2024
94a156f
minor #59234 [Notifier] unsupported options exception (raphael-geffroy)
fabpot Dec 18, 2024
ccf91a1
feature #59192 [PropertyInfo] Add non-*-int missing types for PhpStan…
fabpot Dec 18, 2024
2bfcd89
[AssetMapper] Adding 'Everything up to date' message
ThomasLandauer Dec 11, 2024
892ab6f
minor #59178 [AssetMapper] Adding 'Everything up to date' message (Th…
fabpot Dec 18, 2024
7d6b9ad
feature #59177 [JsonEncoder] Add native lazyghost support (mtarld)
fabpot Dec 18, 2024
dd061aa
feature #59022 [HttpFoundation] Generate url-safe hashes for signed u…
fabpot Dec 18, 2024
23d7763
fix an undefined key error when trying to fetch a missing section
Dec 18, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 2 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,7 @@
/src/Symfony/Component/Translation/Bridge export-ignore
/src/Symfony/Component/Emoji/Resources/data/* linguist-generated=true
/src/Symfony/Component/Intl/Resources/data/*/* linguist-generated=true
/src/Symfony/Component/JsonEncoder/Tests/Fixtures/encoder/* linguist-generated=true
/src/Symfony/Component/JsonEncoder/Tests/Fixtures/decoder/* linguist-generated=true
/src/Symfony/**/.github/workflows/close-pull-request.yml linguist-generated=true
/src/Symfony/**/.github/PULL_REQUEST_TEMPLATE.md linguist-generated=true
9 changes: 9 additions & 0 deletions .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ jobs:
mode: low-deps
- php: '8.3'
- php: '8.4'
# brotli and zstd extensions are optional, when not present the commands will be used instead,
# we must test both scenarios
extensions: amqp,apcu,brotli,igbinary,intl,mbstring,memcached,redis,relay,zstd
- php: '8.5'
#mode: experimental
fail-fast: false
Expand All @@ -54,6 +57,12 @@ jobs:
extensions: "${{ matrix.extensions || env.extensions }}"
tools: flex

- name: Install optional commands
if: matrix.php == '8.4'
run: |
sudo apt-get update
sudo apt-get install zopfli

- name: Configure environment
run: |
git config --global user.email ""
Expand Down
2 changes: 2 additions & 0 deletions .php-cs-fixer.dist.php
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@
->notPath('Symfony/Component/ErrorHandler/Tests/DebugClassLoaderTest.php')
// stop removing spaces on the end of the line in strings
->notPath('Symfony/Component/Messenger/Tests/Command/FailedMessagesShowCommandTest.php')
// disable to not apply `native_function_invocation` rule, as we explicitly break it for testability reason, ref https://github.com/symfony/symfony/pull/59195
->notPath('Symfony/Component/Mailer/Transport/NativeTransportFactory.php')
// auto-generated proxies
->notPath('Symfony/Component/Cache/Traits/RelayProxy.php')
->notPath('Symfony/Component/Cache/Traits/Redis5Proxy.php')
Expand Down
1 change: 1 addition & 0 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@
"symfony/http-foundation": "self.version",
"symfony/http-kernel": "self.version",
"symfony/intl": "self.version",
"symfony/json-encoder": "self.version",
"symfony/ldap": "self.version",
"symfony/lock": "self.version",
"symfony/mailer": "self.version",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ public function getIterator(): \Traversable

public function count(): int
{
return count($this->array);
return \count($this->array);
}
};

Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Bridge/PhpUnit/bin/simple-phpunit.php
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
}

if (version_compare($PHPUNIT_VERSION, '10.0', '>=') && version_compare($PHPUNIT_VERSION, '11.0', '<')) {
fwrite(STDERR, 'This script does not work with PHPUnit 10.'.\PHP_EOL);
fwrite(\STDERR, 'This script does not work with PHPUnit 10.'.\PHP_EOL);
exit(1);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public function testGenerateFragmentUri()
]);
$twig->addRuntimeLoader($loader);

$this->assertSame('/_fragment?_hash=XCg0hX8QzSwik8Xuu9aMXhoCeI4oJOob7lUVacyOtyY%3D&amp;_path=template%3Dfoo.html.twig%26_format%3Dhtml%26_locale%3Den%26_controller%3DSymfony%255CBundle%255CFrameworkBundle%255CController%255CTemplateController%253A%253AtemplateAction', $twig->render('index'));
$this->assertSame('/_fragment?_hash=XCg0hX8QzSwik8Xuu9aMXhoCeI4oJOob7lUVacyOtyY&amp;_path=template%3Dfoo.html.twig%26_format%3Dhtml%26_locale%3Den%26_controller%3DSymfony%255CBundle%255CFrameworkBundle%255CController%255CTemplateController%253A%253AtemplateAction', $twig->render('index'));
}

protected function getFragmentHandler($returnOrException): FragmentHandler
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Bridge/Twig/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"symfony/finder": "^6.4|^7.0",
"symfony/form": "^6.4|^7.0",
"symfony/html-sanitizer": "^6.4|^7.0",
"symfony/http-foundation": "^6.4|^7.0",
"symfony/http-foundation": "^7.3",
"symfony/http-kernel": "^6.4|^7.0",
"symfony/intl": "^6.4|^7.0",
"symfony/mime": "^6.4|^7.0",
Expand Down
7 changes: 7 additions & 0 deletions src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
CHANGELOG
=========

7.3
---

* Add support for assets pre-compression
* Rename `TranslationUpdateCommand` to `TranslationExtractCommand`
* Add JsonEncoder services and configuration

7.2
---

Expand Down
6 changes: 3 additions & 3 deletions src/Symfony/Bundle/FrameworkBundle/Command/AboutCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,9 @@ protected function execute(InputInterface $input, OutputInterface $output): int
['Architecture', (\PHP_INT_SIZE * 8).' bits'],
['Intl locale', class_exists(\Locale::class, false) && \Locale::getDefault() ? \Locale::getDefault() : 'n/a'],
['Timezone', date_default_timezone_get().' (<comment>'.(new \DateTimeImmutable())->format(\DateTimeInterface::W3C).'</>)'],
['OPcache', \extension_loaded('Zend OPcache') ? (filter_var(\ini_get('opcache.enable'), FILTER_VALIDATE_BOOLEAN) ? 'Enabled' : 'Not enabled') : 'Not installed'],
['APCu', \extension_loaded('apcu') ? (filter_var(\ini_get('apc.enabled'), FILTER_VALIDATE_BOOLEAN) ? 'Enabled' : 'Not enabled') : 'Not installed'],
['Xdebug', \extension_loaded('xdebug') ? ($xdebugMode && 'off' !== $xdebugMode ? 'Enabled (' . $xdebugMode . ')' : 'Not enabled') : 'Not installed'],
['OPcache', \extension_loaded('Zend OPcache') ? (filter_var(\ini_get('opcache.enable'), \FILTER_VALIDATE_BOOLEAN) ? 'Enabled' : 'Not enabled') : 'Not installed'],
['APCu', \extension_loaded('apcu') ? (filter_var(\ini_get('apc.enabled'), \FILTER_VALIDATE_BOOLEAN) ? 'Enabled' : 'Not enabled') : 'Not installed'],
['Xdebug', \extension_loaded('xdebug') ? ($xdebugMode && 'off' !== $xdebugMode ? 'Enabled ('.$xdebugMode.')' : 'Not enabled') : 'Not installed'],
];

$io->table([], $rows);
Expand Down
Loading
Loading