[Mailer] Fix Sendmail memory leak #59256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
nicolas-grekas
approved these changes
Jan 7, 2025
| @@ -114,7 +114,7 @@ protected function doSend(SentMessage $message): void | |||
| $this->stream->setCommand($command); | |||
| $this->stream->initialize(); | |||
| foreach ($chunks as $chunk) { | |||
| $this->stream->write($chunk); | |||
| $this->stream->write($chunk, false); | |||
There was a problem hiding this comment.
For next reviewers: this sets the debug flag, so that the stream instance doesn't keep a string copy of what was written. This debug info is not accessible anywhere anyway.
That's similar to:
https://github.com/rch7/symfony/blob/c74e2a3d7e1df817b2bea7d8f6a8fc3373c445bb/src/Symfony/Component/Mailer/Transport/Smtp/SmtpTransport.php#L222
|
Thank you @rch7. |
This was referenced Jan 29, 2025
Merged
Merged
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR: #59239
Fixes issue #50486 (Sendmail transport runs out of memory).
So for example if you have loop sending personalized emails to 200,000 subscribers 20 kB each, $this->debug becomes 4 GB, plus overhead, and the script runs out of resources.
The fix eliminates the problem.