[SecurityBundle] Do not replace authenticators service by their traceable version #59278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MatTheCat
commented
Dec 21, 2024
•
| Q | A |
|---|---|
| Branch? | 7.2 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | Fix #59071, fix #59091 |
| License | MIT |
ac1a9c5 to
e4c66eb
Compare
This was referenced Dec 23, 2024
Closed
chalasr
approved these changes
Dec 23, 2024
|
Hm there shouldn’t be anything unfortunate here; did I miss something? 😅 The |
|
Just the fact we cannot stick with regular service decoration. |
e4c66eb to
ffbd82c
Compare
fabpot
reviewed
Dec 29, 2024
src/Symfony/Bundle/SecurityBundle/DependencyInjection/SecurityExtension.php
Show resolved
Hide resolved
c9c19ab to
111913e
Compare
fabpot
approved these changes
Dec 30, 2024
111913e to
d44b7af
Compare
|
Thank you @MatTheCat. |
Merged
fabpot
added a commit
that referenced
this pull request
Jan 2, 2025
…security.helper` (MatTheCat) This PR was merged into the 7.2 branch. Discussion ---------- [SecurityBundle] Do not pass traceable authenticators to `security.helper` | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #59341 | License | MIT Since #59278 authenticators are no longer aliases for their traceable version, which means calling `Security::login` with an authenticator ID won’t match its traceable ID, and fail. Plus, `Security::login` using the traceable authenticators meant the profiler could show them as successful while not supporting the request:  This PR fixes these issues by passing the original authenticators to `security.helper`, using their ID as name. Commits ------- c5a2360 [SecurityBundle] Do not pass traceable authenticators to `security.helper`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.