[Yaml] Fix parsing of unquoted strings in Parser::lexUnquotedString() to ignore spaces #59312
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
| public function testWrappedUnquotedStringWithMultipleSpacesInValue(string $yaml, array $expected) | ||
| { | ||
| $this->assertSame($expected, $this->parser->parse($yaml)); | ||
| } |
There was a problem hiding this comment.
please add a blank line after the closing curly brace
| { | ||
| $this->assertSame($expected, $this->parser->parse($yaml)); | ||
| } | ||
| public static function WrappedUnquotedStrings() { |
There was a problem hiding this comment.
| public static function WrappedUnquotedStrings() { | |
| public static function wrappedUnquotedStringsProvider() | |
| { |
| @@ -1710,6 +1710,32 @@ public function testBackslashInQuotedMultiLineString() | |||
| $this->assertSame($expected, $this->parser->parse($yaml)); | |||
| } | |||
|
|
|||
| /** | |||
| * @dataProvider WrappedUnquotedStrings | |||
There was a problem hiding this comment.
| * @dataProvider WrappedUnquotedStrings | |
| * @dataProvider wrappedUnquotedStringsProvider |
| } | ||
| public static function WrappedUnquotedStrings() { | ||
| return [ | ||
| 'CurlyBraces' => [ |
There was a problem hiding this comment.
| 'CurlyBraces' => [ | |
| 'mapping' => [ |
| 'fiz' => 'cat cat', | ||
| ] | ||
| ], | ||
| 'SquareBraces' => [ |
There was a problem hiding this comment.
| 'SquareBraces' => [ | |
| 'sequence' => [ |
|
@xabbuh Thank you for taking the time to review my PR! I really appreciate your feedback and have made the suggested changes. Let me know if there's anything else to adjust! |
… to ignore spaces
|
Thank you @Link1515. |
I modified the
strcspn()call in thelexUnquotedString()method of theParserclass to exclude the space character (' ') from the list of delimiters. This ensures that spaces are no longer considered while parsing unquoted strings.