Skip to content

[Serializer] Fix exception thrown by YamlEncoder #59323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2025
Merged

[Serializer] Fix exception thrown by YamlEncoder #59323

merged 1 commit into from
Jan 6, 2025

Conversation

VincentLanglet
Copy link
Contributor

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix the example given #59306 (comment)
License MIT

DecoderInterface::decode is supposed to throw scoped exception cf

symfony/src/Symfony/Component/Serializer/Encoder/DecoderInterface.php

Lines 33 to 35 in 4078cb1

* @throws UnexpectedValueException
*/
public function decode(string $data, string $format, array $context = []): mixed;

but the YamlEncoder::decode could throw ParseException.
Others similar Encoder, like XmlEncoder or JsonEncoder are throwing NotEncodableValue so I did the same cf example

symfony/src/Symfony/Component/Serializer/Encoder/JsonEncode.php

Lines 41 to 45 in da15553

try {
$encodedJson = json_encode($data, $options);
} catch (\JsonException $e) {
throw new NotEncodableValueException($e->getMessage(), 0, $e);
}

@carsonbot carsonbot added this to the 6.4 milestone Dec 29, 2024
@VincentLanglet VincentLanglet changed the title [Serializer] Fix a typo in NoPrivateNetworkHttpClient [Serializer] Fix exception thrown by YamlEncoder Dec 29, 2024
@VincentLanglet VincentLanglet mentioned this pull request Dec 29, 2024
Merged
@VincentLanglet
Copy link
Contributor Author

I don't think UrlSanitizerTest errors are related...

@OskarStark OskarStark changed the title [Serializer] Fix exception thrown by YamlEncoder [Serializer] Fix exception thrown by YamlEncoder Dec 29, 2024
@fabpot
Copy link
Member

fabpot commented Jan 6, 2025

Thank you @VincentLanglet.

@fabpot fabpot merged commit d3583b9 into symfony:6.4 Jan 6, 2025
5 of 11 checks passed
This was referenced Jan 29, 2025
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Bug Serializer Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@VincentLanglet @fabpot @nicolas-grekas @carsonbot