[ErrorHandler] [A11y] Simple proposal for color updates on error stack traces against colorblindness #59334
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
approved these changes
Dec 31, 2024
|
Thank you, can you add some before and after screenshots? |
Sure! Here's a first try! Before: 
After commit: 
|
xabbuh
approved these changes
Dec 31, 2024
fabpot
approved these changes
Jan 1, 2025
|
Definitely a bug fix. |
|
Thank you @DocFX. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I'm colorblind, slightly. I know it can be a real headache to try colors that can match all colorblindnesses, it's a nightmare, as a lot of them are opposed and as some fixes can actually make things worse for other people.
I just open this with a very small changeset in colors for stack traces. The rest of the debug pages seem OK to me (profiler, tables, etc.). But currently I'm really struggling to read the highlighted lines and the dark red PHP syntax highlighting for native identifiers.
I only changed those colors, trying to make it better.
Feel free to discuss better proposals, like using the WebAIM WCAG 2.0 checker (https://webaim.org/resources/contrastchecker/).
Background to red text: https://webaim.org/resources/contrastchecker/?fcolor=FF7B72&bcolor=2E3136
Highlight to PHP identifiers will fail, but it's almost impossible without changing all colors. 1.94/1 is still acceptable as most characters are non-word: https://webaim.org/resources/contrastchecker/?fcolor=71663ACC&bcolor=FF7B72
If anyone thinks we can come up with better proposals, there you go!
At least this fixes it for me and non-colorblind people around me seem to find it still readable, if not better, too. :)