Skip to content

[Yaml] reject inline notations followed by invalid content #59349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2025
Merged

[Yaml] reject inline notations followed by invalid content #59349

merged 1 commit into from
Jan 6, 2025

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jan 2, 2025

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #59259
License MIT

@carsonbot carsonbot added this to the 6.4 milestone Jan 2, 2025
@carsonbot carsonbot changed the title [Yaml] reject inline notations followed by invalid content [Yaml] reject inline notations followed by invalid content Jan 2, 2025
@xabbuh xabbuh mentioned this pull request Jan 2, 2025
Closed
maxbeckers
maxbeckers approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@maxbeckers maxbeckers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it a bit, LGTM.

@fabpot
Copy link
Member

fabpot commented Jan 6, 2025

Thank you @xabbuh.

@fabpot fabpot merged commit 8a3a57d into symfony:6.4 Jan 6, 2025
11 checks passed
@fabpot
Copy link
Member

fabpot commented Jan 6, 2025

@maxbeckers Thanks for testing this patch.

@xabbuh xabbuh deleted the issue-59259 branch January 6, 2025 07:42
@alexpott
Copy link
Contributor

alexpott commented Jan 6, 2025

This commit introduced a regression - see #59378

This was referenced Jan 29, 2025
Merged
Merged
Merged
@GromNaN GromNaN mentioned this pull request Feb 7, 2025
Merged
@renovate renovate bot mentioned this pull request Feb 13, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@maxbeckers maxbeckers maxbeckers approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed Yaml
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
5 participants
@xabbuh @fabpot @alexpott @maxbeckers @carsonbot