[Messenger] Implement KeepaliveReceiverInterface in Redis bridge
#59360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HypeMC
commented
Jan 4, 2025
Comment on lines
+637
to
+644
| $this->getRedis()->xclaim( | ||
| $this->stream, | ||
| $this->group, | ||
| $this->consumer, | ||
| 0, | ||
| [$id], | ||
| ['JUSTID'] | ||
| ); |
There was a problem hiding this comment.
XCLAIM will keep resetting the idle time to zero.
chalasr
approved these changes
Jan 5, 2025
fabpot
approved these changes
Jan 5, 2025
|
Thank you @HypeMC. |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Mar 10, 2025
This PR was merged into the 7.3 branch. Discussion ---------- [Messenger] Keepalive support for Doctrine & Redis Contains #20736 which should be merged first. Keepalive support for the Doctrine and Redis transports was added in symfony/symfony#59601 and symfony/symfony#59360, respectively. Commits ------- abdd3c9 [Messenger] Keepalive support for Doctrine & Redis
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the
KeepaliveReceiverInterfacein the Redis bridge.