Skip to content

[Yaml] fix inline notation with inline comment #59381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2025
Merged

[Yaml] fix inline notation with inline comment #59381

merged 1 commit into from
Jan 7, 2025

Conversation

alexpott
Copy link
Contributor

@alexpott alexpott commented Jan 6, 2025

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #59378
License MIT

Recent commit broke parsing yam like:

calls:
  # This is a temporary measure. JSON:API should not need to be aware of the Content Moderation module.
  - [setLatestRevisionCheck, ['@?access_check.latest_revision']] # This is only injected when the service is available.

This MR adds a test and fixes this.

@carsonbot carsonbot added this to the 7.3 milestone Jan 6, 2025
@alexpott alexpott changed the base branch from 7.3 to 6.4 January 6, 2025 23:36
@carsonbot carsonbot changed the title 59378 fix inline notation with inline comment [Yaml] 59378 fix inline notation with inline comment Jan 7, 2025
@nicolas-grekas nicolas-grekas changed the title [Yaml] 59378 fix inline notation with inline comment [Yaml] fix inline notation with inline comment Jan 7, 2025
@nicolas-grekas nicolas-grekas modified the milestones: 7.3, 6.4 Jan 7, 2025
@symfony symfony deleted a comment from carsonbot Jan 7, 2025
@nicolas-grekas nicolas-grekas force-pushed the 59378-fix-inline-notation-with-inline-comment branch from 1fc3b02 to dccac0b Compare January 7, 2025 09:44
@nicolas-grekas
Copy link
Member

Thank you @alexpott.

@nicolas-grekas nicolas-grekas merged commit 82011ee into symfony:6.4 Jan 7, 2025
11 checks passed
This was referenced Jan 29, 2025
Merged
Merged
Merged
@GromNaN GromNaN mentioned this pull request Feb 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

@maxbeckers maxbeckers maxbeckers approved these changes

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

@yceruto yceruto Awaiting requested review from yceruto

Assignees
No one assigned
Labels
Bug Status: Reviewed Yaml
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

Inline yaml comments broken after recent commit
5 participants
@alexpott @nicolas-grekas @xabbuh @maxbeckers @carsonbot