[VarDumper] Fix blank strings display #59390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7b693f2 to
4a43bad
Compare
| "<pre class=sf-dump id=sf-dump data-indent-pad=\" \"><span class=sf-dump-num>123</span>\n</pre><script>Sfdump(\"sf-dump\")</script>\n" | ||
| ."<pre class=sf-dump id=sf-dump data-indent-pad=\" \"><span class=sf-dump-num>456</span>\n</pre><script>Sfdump(\"sf-dump\")</script>\n", | ||
| "<pre class=sf-dump id=sf-dump data-indent-pad=\" \"><span class=\"sf-dump-num\">123</span>\n</pre><script>Sfdump(\"sf-dump\")</script>\n" | ||
| ."<pre class=sf-dump id=sf-dump data-indent-pad=\" \"><span class=\"sf-dump-num\">456</span>\n</pre><script>Sfdump(\"sf-dump\")</script>\n", |
There was a problem hiding this comment.
this change breaks low-deps
better preserve the previous output when possible to not have to change version constraints
doable?
There was a problem hiding this comment.
I think I could quote the class attribute only if there are two indeed (would feel weird though 😅)
There was a problem hiding this comment.
that'd help fix tests (they're still red :) )
There was a problem hiding this comment.
Wouldn’t high and low-deps tests eventually pass when the code is released?
Anyways, I limited the changes to ellipsization so that other components’ tests are not impacted 🟢
8133832 to
59d0af8
Compare
59d0af8 to
b0c2a59
Compare
|
Thank you @MatTheCat. |
This was referenced Jan 29, 2025
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
sf-dump-ellipsisspans needed atext-ellipsis, their overflowing content was cut usingoverflow: hidden. As it required their inner display type to beblock, this broke the alignment with the ellipsis’ “tail”. This was fixed by #53147 by making every dump’sspansinline-flex.This change made
sf-dump-ellipsis’display,max-widthandvertical-alignproperties useless so this PR removes them, as well as a duplicatedoverflowone.Now,
inline-flexelements’ content becomes flex items, which caused #57980 becauseInstead of making every dump’s
spansinline-flex, this PR targets a newsf-dump-ellipsizationclass added tosf-dump-ellipsis’ parents.It also wraps ellipsis tails with elements bearing the
sf-dump-ellipsis-tailclass so that we can prevent them to shrink:Before:
After: