[JsonEncoder] Allow to warm up arbitrary types #59396
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aa66777 to
11a0a1f
Compare
11a0a1f to
8ab422f
Compare
|
#59536 is an alternative approach to tackle this issue. |
fabpot
added a commit
that referenced
this pull request
Jan 25, 2025
This PR was merged into the 7.3 branch. Discussion ---------- [JsonEncoder] Allow to warm up object and list | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | | License | MIT As discussed with `@chalasr`, configuration in FrameworkBundle must be avoided as much as possible. That's why #59396 might not be the way to go. Instead, this PR addresses the most common use cases, which are warming up cache files for `GivenClass` and `list<GivenClass>`. This can be configured by setting the `object` and `list` attributes of `json_encoder.encodable`, or `asObject` and `asList` of the `JsonEncodable` attribute accordingly. Commits ------- cb36ec0 [JsonEncoder] Allow to warm up item and list
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Jan 25, 2025
This PR was merged into the 7.3 branch. Discussion ---------- [JsonEncoder] Allow to warm up object and list | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | | License | MIT As discussed with `@chalasr`, configuration in FrameworkBundle must be avoided as much as possible. That's why symfony/symfony#59396 might not be the way to go. Instead, this PR addresses the most common use cases, which are warming up cache files for `GivenClass` and `list<GivenClass>`. This can be configured by setting the `object` and `list` attributes of `json_encoder.encodable`, or `asObject` and `asList` of the `JsonEncodable` attribute accordingly. Commits ------- cb36ec0d09b [JsonEncoder] Allow to warm up item and list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to configure types that will be warmed up during cache generation:
This allows to pre-generate encoders/decoders for types we know that will be used, but that aren't simple classes (such as list of classes for example).