[DomCrawler] Make ChoiceFormField::isDisabled return true for unchecked disabled checkboxes
#59399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChoiceFormField::isDisabled return true for disabled checkboxesChoiceFormField::isDisabled return true for unchecked disabled checkboxes
…hecked disabled checkboxes
nicolas-grekas
approved these changes
Jan 17, 2025
|
Thank you @MatTheCat. |
This was referenced Jan 29, 2025
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChoiceFormField::isDisabled’s PHPDoc readsBut a checkbox really embeds two options: either you check it, or not; which means it always has a selected option.
Then, if a checkbox is disabled, these two options are too.
So,
ChoiceFormField::isDisabledshould returntruefor disabled checkboxes, checked or not.This also matches what you intuitively would expect from this method.