[Mailer] [Smtp] Add DSN param to enforce TLS/STARTTLS #59479
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
9243f56 to
f4af5aa
Compare
src/Symfony/Component/Mailer/Transport/Smtp/EsmtpTransportFactory.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Tests/Transport/Smtp/EsmtpTransportTest.php
Outdated
Show resolved
Hide resolved
bd5e626 to
eae0ffe
Compare
|
Thanks for the review @mtarld. |
Adds 'require_tls' param which can be set to true to enforce the use of TLS/STARTTLS within the ESMTP transport.
eae0ffe to
a93d5f6
Compare
|
Thank you @ssddanbrown. |
Adds 'require_tls' param which can be set to true to enforce the use of TLS/STARTTLS within the ESMTP transport.
This was discussed in #48297.
These changes are based upon patches I've been maintaining for my own projects.
This is my first PR to Symfony, I've tried to follow the guide as best as possible, and I was also using #53621 as a general guide. There are some other ways I could have gone about things, but I've tried to avoid touching as much existing Symfony code as possible.
In #48297, nicolas-grekas mentioned unifying such an option with
auto_tlsunder atlsoption, but I think these are distinct options which may not be as clear combined (in addition to any expectations of such an option disabling/enabling TLS in general).