Skip to content

[Serializer] [ObjectNormalizer] Filter int when using FILTER_BOOL #59501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2025
Merged

[Serializer] [ObjectNormalizer] Filter int when using FILTER_BOOL #59501

merged 1 commit into from
Jan 17, 2025

Conversation

DjordyKoert
Copy link
Contributor

@DjordyKoert DjordyKoert commented Jan 14, 2025 •
edited by nicolas-grekas
Loading

Q A
Branch? 7.1
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix ...
License MIT

Improves on #57541 to also allow numeric values 1 and 0 with FILTER_BOOL => true

Currently attempting to use the Serializer component to deserialize to deserialize a 1 or 0 result in the following error:

The type of the "booleanProperty" attribute for class "App\MyDTO" must be one of "bool" ("int" given).

@DjordyKoert DjordyKoert requested a review from dunglas as a code owner January 14, 2025 13:27
@carsonbot carsonbot added this to the 7.2 milestone Jan 14, 2025
@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.2" but it seems your PR description refers to branch "7.1 / 7.2".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@nicolas-grekas nicolas-grekas modified the milestones: 7.2, 7.1 Jan 17, 2025
@nicolas-grekas nicolas-grekas changed the base branch from 7.2 to 7.1 January 17, 2025 09:54
@nicolas-grekas
Copy link
Member

Thank you @DjordyKoert.

@nicolas-grekas nicolas-grekas merged commit 717ca76 into symfony:7.1 Jan 17, 2025
4 of 11 checks passed
This was referenced Jan 29, 2025
Merged
Merged
@Hanmac Hanmac mentioned this pull request Jan 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

@xabbuh xabbuh Awaiting requested review from xabbuh

@lyrixx lyrixx Awaiting requested review from lyrixx

@yceruto yceruto Awaiting requested review from yceruto

@welcoMattic welcoMattic Awaiting requested review from welcoMattic

@kbond kbond Awaiting requested review from kbond

@chalasr chalasr Awaiting requested review from chalasr

@OskarStark OskarStark Awaiting requested review from OskarStark

@jderusse jderusse Awaiting requested review from jderusse

Assignees
No one assigned
Labels
Bug Serializer Status: Needs Review
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.
3 participants
@DjordyKoert @carsonbot @nicolas-grekas