Skip to content

[Lock] make check with prefix more robust #59521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

PatNowak
Copy link

Q A
Branch? 7.2
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #59387
License MIT

Making the #59387 more robust and future proof.

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.3" but it seems your PR description refers to branch "7.2".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@PatNowak PatNowak changed the base branch from 7.3 to 7.2 January 16, 2025 12:09
@PatNowak PatNowak changed the title Issue 59387 2 Issue 59387-2: make check with prefix more robust Jan 16, 2025
@fabpot fabpot modified the milestones: 7.3, 7.2 Jan 17, 2025
@fabpot
Copy link
Member

fabpot commented Jan 17, 2025

Thank you @PatNowak.

@fabpot fabpot merged commit 561f1fb into symfony:7.2 Jan 17, 2025
4 of 9 checks passed
@carsonbot carsonbot changed the title Issue 59387-2: make check with prefix more robust [Lock] Issue 59387-2: make check with prefix more robust Jan 17, 2025
@OskarStark OskarStark changed the title [Lock] Issue 59387-2: make check with prefix more robust [Lock] make check with prefix more robust Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lock] Lock::acquire will always return false when using RedisStore
5 participants