[Security] Unset token roles when serializing it and user implements EquatableInterface #59558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/Security/Core/Authentication/Token/AbstractToken.php
Show resolved
Hide resolved
alexandre-daubois
approved these changes
Jan 20, 2025
This affirmation looks weird to me. The RoleVoter reads them when voting on roles. |
|
Yes sure, I meant from the pov of ContextListenet::hasUserChanged, which contains this bypass: symfony/src/Symfony/Component/Security/Http/Firewall/ContextListener.php Lines 286 to 288 in 5cab1e1 |
…EquatableInterface
b92aae3 to
b7c55c8
Compare
|
Friendly ping @symfony/mergers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user object implement EquatableInterface, we never read the roles stored in the token object that wraps the user in the session storage.
This PR ensures we don't store these roles either - they're just wasting space.