[Validator] Fix constraints deprecations #59561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Jan 20, 2025
| @@ -93,7 +93,7 @@ public function __construct( | |||
| } | |||
|
|
|||
| if ($options) { | |||
There was a problem hiding this comment.
shoudn't this be if (\is_array($options)) { everywhere?
There was a problem hiding this comment.
I agree, otherwise an empty array will not trigger the deprecation. Should this be taken care in a separate PR or this one's fine?
There was a problem hiding this comment.
It detected a missing test update, it should be good now
d4b37d1 to
d23909e
Compare
d23909e to
89b7a2e
Compare
|
Thank you @alexandre-daubois. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small tweak after the recent merge when having a look at the commit 🙂
(see #54744)
cc @xabbuh