Skip to content

[Config] Add missing json_encode flags when creating .meta.json files #59580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Jan 22, 2025

Q A
Branch? 7.2
Bug fix? yes
New feature? no
Deprecations? no
Issues -
License MIT

So that cache:clear can find refs to var/cache/de_ and patch them. (currently it fails as those are encoded as var\/cache\/de_.)

Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, the test failures are related.

@nicolas-grekas
Copy link
Member Author

Oops, fixed!

@OskarStark OskarStark changed the title [Config] Add missing json_encode flag when creating .meta.json files [Config] Add missing json_encode flags when creating .meta.json files Jan 22, 2025
@nicolas-grekas nicolas-grekas merged commit b765290 into symfony:7.2 Jan 22, 2025
11 checks passed
@fabpot fabpot mentioned this pull request Jan 29, 2025
@nicolas-grekas nicolas-grekas deleted the config-unescape branch January 29, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants