[Mime] use isRendered method to ensure we can avoid rendering an emai… #59592
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
Hey! Thanks for your PR. You are targeting branch "7.3" but it seems your PR description refers to branch "6.2". Cheers! Carsonbot |
|
@carsonbot I did change the targeting branch |
|
Should I address this report ? Because it is a bugfix, I'd like to provide the minimal diff, so my first guess is to not commit more changes. |
|
The 6.2 branch is not maintained anymore. You can see maintained branches on https://symfony.com/releases |
|
Thank you @stof |
|
I deleted this PR accidentally. I did open another here: #59596 |
…l twice
Following up my comment on https://github.com/symfony/symfony/pull/47075/files.
I would recommend using the method TemplatedEmail::isRendered() the same way it is used in AbstractTransport.php.
Keeping like this prevents subclass of TemplatedEmail with computed html template to not be rendered twice, such as NotificationEmail.
This change will allow developers to create a subclass of template emails and render them before sending them async, without rendering them twice.