[DomCrawler] Don't return file infos for empty file fields #59621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
Let me close as that cannot be the correct solution. The changes in the test cases highlight how this might break existing apps. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 11, 2025
…nicolas-grekas) This PR was merged into the 6.4 branch. Discussion ---------- [BrowserKit] Fix submitting forms with empty file fields | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #49014 | License | MIT Replaces #53586 and #59621 Commits ------- 0fbfc3e [BrowserKit] Fix submitting forms with empty file fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49014 but not in a meaningful way IMO. But I don't know where else to remove empty files. Could be in
Request(browser-kit), or even later inMultipartPart(mime). I don't understand why dom-crawler works this way, so I don't know how to fix it correctly.To do: fix tests..?