Skip to content

[JsonEncoder] Add missing changelog entries #59624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

mtarld
Copy link
Contributor

@mtarld mtarld commented Jan 27, 2025

Q A
Branch? 7.3
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

Even if the component is experimental and not released, the CHANGELOG entries must be kept up to date.
This PR adds the missing ones.

@fabpot
Copy link
Member

fabpot commented Jan 27, 2025

Good catch, thanks @mtarld.

@fabpot fabpot merged commit 2db2b46 into symfony:7.3 Jan 27, 2025
9 of 11 checks passed
@mtarld mtarld deleted the fix/json-encoder-changelog branch January 27, 2025 10:41
@xabbuh
Copy link
Member

xabbuh commented Jan 27, 2025

This does not make sense to me as the component was not part of any release yet (and we do not document changes that only happen during the development phase of an upcoming release).

@fabpot
Copy link
Member

fabpot commented Jan 27, 2025

Oops, I'm sure why I thought it was introduced in 7.2. I'm going to remove all the changelog but the "Introduce the component" line.

@fabpot
Copy link
Member

fabpot commented Jan 27, 2025

See 5dcde9d

@mtarld
Copy link
Contributor Author

mtarld commented Jan 27, 2025

My bad, I thought it was useful for the development history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants