Skip to content

[Lock] Fix Predis error handling #59661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2025
Merged

[Lock] Fix Predis error handling #59661

merged 1 commit into from
Feb 4, 2025

Conversation

HypeMC
Copy link
Contributor

@HypeMC HypeMC commented Jan 30, 2025 •
edited by xabbuh
Loading

Q A
Branch? 7.2
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #59686
License MIT

#59348 completely broke the Redis store when used with a service, eg:

framework:
  lock:
    resources:
      default: snc_redis.default

The assumption that exceptions is always false is only correct when a DSN is used.

@HypeMC HypeMC requested a review from jderusse as a code owner January 30, 2025 22:48
@carsonbot carsonbot added this to the 7.2 milestone Jan 30, 2025
@andrew-demb
Copy link
Contributor

We have the same problem as described in the description. We're using for symfony/lock different Redis connection than for symfony/cache.

Thanks for the PR

@andrew-demb
Copy link
Contributor

CI failure seems unrelated (failed tests are from symfony/process test suite)

@xabbuh xabbuh mentioned this pull request Feb 4, 2025
Closed
@xabbuh xabbuh linked an issue Feb 4, 2025 that may be closed by this pull request
[Lock] "NOSCRIPT No matching script. Please use EVAL." after updating to symfony/lock 7.2.3 #59686
Closed
@nicolas-grekas
Copy link
Member

Thank you @HypeMC.

@nicolas-grekas nicolas-grekas merged commit c633647 into symfony:7.2 Feb 4, 2025
7 of 11 checks passed
@HypeMC HypeMC deleted the fix-predis-lock branch February 4, 2025 14:27
@ro0NL ro0NL mentioned this pull request Feb 19, 2025
Open
@fabpot fabpot mentioned this pull request Feb 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@jderusse jderusse Awaiting requested review from jderusse jderusse is a code owner

Assignees
No one assigned
Labels
Bug Lock Status: Needs Review
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.

[Lock] "NOSCRIPT No matching script. Please use EVAL." after updating to symfony/lock 7.2.3
5 participants
@HypeMC @andrew-demb @nicolas-grekas @stof @carsonbot