[HttpClient] pass CURLOPT_INFILESIZE_LARGE only when supported #59695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Feb 4, 2025
92df1e0 to
da6c052
Compare
|
Thank you @xabbuh. |
OskarStark
reviewed
Feb 4, 2025
| @@ -316,8 +316,8 @@ public function request(string $method, string $url, array $options = []): Respo | |||
| } | |||
|
|
|||
| foreach ($curlopts as $opt => $value) { | |||
| if (\CURLOPT_INFILESIZE === $opt && $value >= 1 << 31) { | |||
| $opt = 115; // 115 === CURLOPT_INFILESIZE_LARGE, but it's not defined in PHP | |||
| if (\PHP_INT_SIZE === 8 && \defined('CURLOPT_INFILESIZE_LARGE') && \CURLOPT_INFILESIZE === $opt && $value >= 1 << 31) { | |||
There was a problem hiding this comment.
But before the assignment also happened when the constant is not defined, right? Now it need to be defined 🤔
There was a problem hiding this comment.
The cURL extension doesn't support option it doesn't know: https://github.com/php/php-src/blob/790286ab6c8954193bbbca778749550a51aceb97/ext/curl/interface.c#L2358
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following #59654