Skip to content

[HttpClient] curl_multi_select() timeout must be positive #59708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[HttpClient] curl_multi_select() timeout must be positive #59708

wants to merge 2 commits into from

Conversation

PhilETaylor
Copy link
Contributor

@PhilETaylor PhilETaylor commented Feb 5, 2025 •
edited by xabbuh
Loading

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #59041
License MIT

Ensure that the timeout can never be negative
Blind proposed based on #59041

@carsonbot carsonbot added this to the 6.4 milestone Feb 5, 2025
@PhilETaylor PhilETaylor mentioned this pull request Feb 5, 2025
Closed
@PhilETaylor
curl_multi_select(): timeout must be positive symfony#59041
af2bdad 
Signed-off-by: Phil E. Taylor <phil@phil-taylor.com>
@PhilETaylor @xabbuh
Update CurlResponse.php
1dd704d 
Co-authored-by: Christian Flothmann <christian.flothmann@gmail.com>
@xabbuh xabbuh removed the Feature label Feb 6, 2025
fabpot
fabpot approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me

@OskarStark OskarStark changed the title [HttpClient] curl_multi_select(): timeout must be positive #59041 [HttpClient] curl_multi_select() timeout must be positive Feb 7, 2025
@nicolas-grekas
Copy link
Member

Thanks for giving this a try but this cannot be correct.
Can you please try #59727 and see if you reproduce the issue with it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh left review comments

@Chris53897 Chris53897 Chris53897 left review comments

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Bug HttpClient Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
6 participants
@PhilETaylor @nicolas-grekas @fabpot @xabbuh @Chris53897 @carsonbot