[DependencyInjection] Fix cloned lazy services not sharing their dependencies when dumped with PhpDumper #59723
+168
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Feb 7, 2025
src/Symfony/Component/DependencyInjection/Compiler/InlineServiceDefinitionsPass.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Tests/Fixtures/php/services_wither_lazy.php
Outdated
Show resolved
Hide resolved
cba91d9 to
9ea5995
Compare
|
Updated. I don't think the failing tests are related. |
GromNaN
reviewed
Feb 7, 2025
src/Symfony/Component/DependencyInjection/Compiler/InlineServiceDefinitionsPass.php
Show resolved
Hide resolved
...ymfony/Component/DependencyInjection/Tests/Fixtures/php/services_almost_circular_private.php
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Feb 7, 2025
src/Symfony/Component/DependencyInjection/Tests/Fixtures/DependencyContainerInterface.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Tests/Fixtures/DependencyContainerInterface.php
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Tests/Fixtures/DependencyContainer.php
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Tests/Fixtures/DependencyContainer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Tests/Fixtures/DependencyContainer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Tests/Fixtures/DependencyContainer.php
Outdated
Show resolved
Hide resolved
9ea5995 to
c93c0d5
Compare
|
Resolved style comments |
GromNaN
approved these changes
Feb 7, 2025
|
Note that when using native proxies, cloning will trigger initialization. (The patch is still fixing a valid concern since we're not coupled to one implementation) |
…ndencies when dumped with PhpDumper
c93c0d5 to
a60cff5
Compare
|
Thank you @pvandommelen. |
|
Thanks for the quick reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes referenced services not being shared when lazy services are cloned before being initialized. Adds tests for both the ghost and proxy scenario's.
This makes the inlining behaviour more conservative, which impacts the outputs of some other test cases.
First commit adds a test, second commit has the fix. Third commit also considers the proxy case, which is also affected. I can squash if necessary.
Targeted 6.4, but this also applies to 7.x.