Enable JSON_PRESERVE_ZERO_FRACTION in jsonRequest method
#59769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "7.3" but it seems your PR description refers to branch "7.2". Cheers! Carsonbot |
JSON_PRESERVE_ZERO_FRACTION in jsonRequest method
961c9ae to
b8fcd13
Compare
|
this needs a regression tests (which would also help understand which issue is being fixed) |
test added |
|
Will be cast to int 0? Or do you mean cast to int 10 in the pr description? |
nicolas-grekas
approved these changes
Feb 13, 2025
JSON_PRESERVE_ZERO_FRACTION in jsonRequest methodJSON_PRESERVE_ZERO_FRACTION in jsonRequest method
10, sorry. |
OskarStark
approved these changes
Feb 13, 2025
mtarld
approved these changes
Feb 14, 2025
fabpot
approved these changes
Feb 14, 2025
b066b65 to
535953e
Compare
|
Thank you @raffaelecarelle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the jsonRequest method to use JSON_PRESERVE_ZERO_FRACTION when encoding parameters.
This avoid unintended cast to int.
Test case:
"cost" will be cast to int
10