Skip to content

[TwigBridge] Fix compatibility with Twig 3.21 #59774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

alexandre-daubois
Copy link
Member

@alexandre-daubois alexandre-daubois commented Feb 14, 2025

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues -
License MIT

Parser::getExpressionParser() is deprecated since Twig 3.21.

@alexandre-daubois alexandre-daubois force-pushed the fix-twig-bridge-compat-3.21 branch from 06d8779 to 5953ff7 Compare February 14, 2025 09:54
Copy link
Member

@stof stof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When merging this to the 7.3 branch, I suggest bumping the min Twig version of the bridge to 3.21 to allow cleaning the legacy code from there (we cannot do that in 6.4 as we still need to support Twig 2.x anyway).

@fabpot
Copy link
Member

fabpot commented Feb 14, 2025

Thank you @alexandre-daubois.

@fabpot fabpot merged commit db15145 into symfony:6.4 Feb 14, 2025
9 of 10 checks passed
@alexandre-daubois alexandre-daubois deleted the fix-twig-bridge-compat-3.21 branch February 14, 2025 11:23
nicolas-grekas added a commit that referenced this pull request Feb 14, 2025
This PR was merged into the 7.3 branch.

Discussion
----------

[TwigBridge] Remove legacy code

| Q             | A
| ------------- | ---
| Branch?       | 7.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | Fix #59774 (review)
| License       | MIT

As suggested in the linked comment.

Commits
-------

ef65035 [TwigBridge] Remove legacy code
This was referenced Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants