-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Mailer] fix multiple transports default injection #59781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fabpot
merged 1 commit into
symfony:6.4
from
fkropfhamer:fix/multiple-mailer-transports
Feb 26, 2025
Merged
[Mailer] fix multiple transports default injection #59781
fabpot
merged 1 commit into
symfony:6.4
from
fkropfhamer:fix/multiple-mailer-transports
Feb 26, 2025
+2
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4a5472b
to
5b78ce1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should target 6.4 I suppose.
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTestCase.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Feb 21, 2025
fabpot
approved these changes
Feb 26, 2025
29a922d
to
a50880b
Compare
Thank you @fkropfhamer. |
renovate bot
added a commit
to Runroom/archetype-symfony
that referenced
this pull request
Feb 28, 2025
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [symfony/framework-bundle](https://symfony.com) ([source](https://redirect.github.com/symfony/framework-bundle)) | `7.2.3` -> `7.2.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [symfony/messenger](https://symfony.com) ([source](https://redirect.github.com/symfony/messenger)) | `7.2.3` -> `7.2.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [symfony/stopwatch](https://symfony.com) ([source](https://redirect.github.com/symfony/stopwatch)) | `7.2.2` -> `7.2.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [symfony/web-profiler-bundle](https://symfony.com) ([source](https://redirect.github.com/symfony/web-profiler-bundle)) | `7.2.3` -> `7.2.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>symfony/framework-bundle (symfony/framework-bundle)</summary> ### [`v7.2.4`](https://redirect.github.com/symfony/framework-bundle/releases/tag/v7.2.4) [Compare Source](https://redirect.github.com/symfony/framework-bundle/compare/v7.2.3...v7.2.4) **Changelog** (symfony/framework-bundle@v7.2.3...v7.2.4) - bug [symfony/symfony#59198](https://redirect.github.com/symfony/symfony/issues/59198) \[Messenger] Filter out non-consumable receivers when registering `ConsumeMessagesCommand` (@​wazum) - bug [symfony/symfony#59781](https://redirect.github.com/symfony/symfony/issues/59781) \[Mailer] fix multiple transports default injection ([@​fkropfhamer](https://redirect.github.com/fkropfhamer)) - bug [symfony/symfony#59829](https://redirect.github.com/symfony/symfony/issues/59829) \[FrameworkBundle] Disable the keys normalization of the CSRF form field attributes ([@​sukei](https://redirect.github.com/sukei)) - bug [symfony/symfony#59728](https://redirect.github.com/symfony/symfony/issues/59728) \[Form]\[FrameworkBundle] Use auto-configuration to make the default CSRF token id apply only to the app; not to bundles ([@​nicolas-grekas](https://redirect.github.com/nicolas-grekas)) </details> <details> <summary>symfony/messenger (symfony/messenger)</summary> ### [`v7.2.4`](https://redirect.github.com/symfony/messenger/releases/tag/v7.2.4) [Compare Source](https://redirect.github.com/symfony/messenger/compare/v7.2.3...v7.2.4) **Changelog** (symfony/messenger@v7.2.3...v7.2.4) - bug [symfony/symfony#59198](https://redirect.github.com/symfony/symfony/issues/59198) \[Messenger] Filter out non-consumable receivers when registering `ConsumeMessagesCommand` (@​wazum) </details> <details> <summary>symfony/stopwatch (symfony/stopwatch)</summary> ### [`v7.2.4`](https://redirect.github.com/symfony/stopwatch/releases/tag/v7.2.4) [Compare Source](https://redirect.github.com/symfony/stopwatch/compare/v7.2.2...v7.2.4) **Changelog** (symfony/stopwatch@v7.2.3...v7.2.4) - no significant changes </details> <details> <summary>symfony/web-profiler-bundle (symfony/web-profiler-bundle)</summary> ### [`v7.2.4`](https://redirect.github.com/symfony/web-profiler-bundle/releases/tag/v7.2.4) [Compare Source](https://redirect.github.com/symfony/web-profiler-bundle/compare/v7.2.3...v7.2.4) **Changelog** (symfony/web-profiler-bundle@v7.2.3...v7.2.4) - bug [symfony/symfony#59776](https://redirect.github.com/symfony/symfony/issues/59776) \[WebProfilerBundle] fix rendering notifier message options ([@​xabbuh](https://redirect.github.com/xabbuh)) - bug [symfony/symfony#59033](https://redirect.github.com/symfony/symfony/issues/59033) \[WebProfilerBundle] Fix interception for non conventional redirects ([@​Huluti](https://redirect.github.com/Huluti)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/Runroom/archetype-symfony). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNzYuMiIsInVwZGF0ZWRJblZlciI6IjM5LjE3Ni4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here #46372
If multiple mailer transports are configured and you try to inject the TransportInterface as a service, only the first one gets injected and not all the Transports. Therefore, X-Transport headers do not work.