[Security] Improve DX of recent additions #59805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a07496e to
8d7316b
Compare
stof
requested changes
Feb 19, 2025
src/Symfony/Component/Security/Core/Authorization/AuthorizationChecker.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Http/EventListener/IsGrantedAttributeListener.php
Show resolved
Hide resolved
8d7316b to
d74e07a
Compare
|
Thanks for the reviews, comments addressed. Status: needs review |
alexandre-daubois
approved these changes
Feb 20, 2025
d74e07a to
aa38eb8
Compare
|
I just removed the |
|
isn't fabbot's patch legit? |
|
I think this alignment rule doesn't work when the type description is too long, so I ignored fabbot on purpose... |
chalasr
approved these changes
Feb 21, 2025
|
Thank you @nicolas-grekas. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #48142 and #59150 which were merged recently into 7.3.
Summary of the changes:
UserAuthorizationChecker, the implementation of the corresponding interface is merged into the existingAuthorizationChecker.AuthorizationChecker::isGranted()is made aware of token changed by its newisGrantedForUser()method, so that calls tois_granted()nested intois_granted_for_user()calls will check the provided user, not the logged in one.IsGranted's closures by 1. a newIsGrantedContextand 2. the$subject. This makes everything simpler, easier to discover, and more extensible. Thanks to the previous item, IsGrantedContext only needs the auth-checker, not the access-decision-manager anymore. Simpler again.