[TypeInfo] Add ArrayShapeType class
#59827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e1bca5b to
294b185
Compare
3660bb4 to
e1d1d9b
Compare
chalasr
approved these changes
Mar 6, 2025
GromNaN
approved these changes
Mar 13, 2025
| foreach ($value as $key => $itemValue) { | ||
| $valueType = $this->shape[$key]['type'] ?? false; | ||
| if (!$valueType) { | ||
| return false; |
There was a problem hiding this comment.
For extra keys, the behavior is different between PHPStan (allow) and psalm (restrict). You implemented the strict version: false is returned when an extra key is present. This is consistent with psalm and PHPStorm 👍🏻
There is a syntax using ... to allow extra keys (demo); but this is not supported by PHPStorm and PHP_CodeSniffer.
/** @param array{foo: string, ...} $a */
function fun(array $a): intThis feature can wait for a subsequent PR.
|
Thank you Mathias. |
fabpot
added a commit
that referenced
this pull request
Mar 26, 2025
This PR was merged into the 7.3 branch. Discussion ---------- [TypeInfo] Add `ArrayShapeType::$sealed` | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | | License | MIT Implement sealed syntax for array shape type, as suggested in #59827 (comment). Commits ------- fded1eb [TypeInfo] Add `ArrayShapeType::$extraKeyType` and `ArrayShapeType::$extraValueType`
symfony-splitter
pushed a commit
to symfony/type-info
that referenced
this pull request
Mar 26, 2025
This PR was merged into the 7.3 branch. Discussion ---------- [TypeInfo] Add `ArrayShapeType::$sealed` | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | | License | MIT Implement sealed syntax for array shape type, as suggested in symfony/symfony#59827 (comment). Commits ------- fded1eb5030 [TypeInfo] Add `ArrayShapeType::$extraKeyType` and `ArrayShapeType::$extraValueType`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the
ArrayShapeTypethat holds the exact shape of an array. Also enables theStringTypeResolverto parsearray{foo: int, bar?: string}and to create the appropriate type.This PR needs #59824 to be merged first.