Skip to content

[Yaml] drop comments while lexing unquoted strings #59830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2025
Merged

[Yaml] drop comments while lexing unquoted strings #59830

merged 1 commit into from
Mar 1, 2025

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Feb 21, 2025

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #59785
License MIT

@carsonbot carsonbot added this to the 6.4 milestone Feb 21, 2025
@xabbuh xabbuh mentioned this pull request Feb 21, 2025
Closed
@stof
Copy link
Member

stof commented Feb 21, 2025

IIRC, a Yaml comment starts with a # that is either at the beginning of the line or is following a whitespace, but url: http://example.com/#about would not treat about as a comment.
Can you add more tests covering such cases ?

@xabbuh
Copy link
Member Author

xabbuh commented Feb 21, 2025

hm indeed

Status: Needs work

@xabbuh xabbuh force-pushed the issue-59785 branch 2 times, most recently from e56733b to 83052dd Compare February 27, 2025 08:01
@xabbuh
Copy link
Member Author

xabbuh commented Feb 27, 2025

should be good now

Status: Needs Review

ro0NL
ro0NL reviewed Feb 27, 2025
View reviewed changes
mtarld
mtarld reviewed Feb 27, 2025
View reviewed changes
@fabpot
Copy link
Member

fabpot commented Mar 1, 2025

Thank you @xabbuh.

@fabpot fabpot merged commit 642b714 into symfony:6.4 Mar 1, 2025
6 of 11 checks passed
@xabbuh xabbuh deleted the issue-59785 branch March 1, 2025 21:30
This was referenced Mar 28, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@fabpot fabpot fabpot approved these changes

@mtarld mtarld mtarld approved these changes

+1 more reviewer

@ro0NL ro0NL ro0NL left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Bug Status: Reviewed Yaml
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
6 participants
@xabbuh @stof @fabpot @ro0NL @mtarld @carsonbot