[Cache] fix cache data collector on late collect #59841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dcmbrs
commented
Feb 23, 2025
•
| Q | A |
|---|---|
| Branch? | 6.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | Fix #59838 |
| License | MIT |
keradus
reviewed
Feb 23, 2025
|
@keradus I added a test |
nicolas-grekas
approved these changes
Feb 24, 2025
fabpot
approved these changes
Feb 24, 2025
|
@dcmbrs Can you rebase tour PR to get rid of the merge commit? Thank you? |
keradus
reviewed
Feb 24, 2025
src/Symfony/Component/Cache/Tests/DataCollector/CacheDataCollectorTest.php
Outdated
Show resolved
Hide resolved
|
I'm sorry I couldn't clean up the merge request commit and I don't know what's going on. I see many commits and changes, I have the impression that 7.3 has been merged onto this branch but yet I haven't pushed anything on my side. Could I get some help? I'm not used to working with forks and rebase Or I do antoher PR et close this ? |
7647b09 to
4b8bb5c
Compare
|
(I fixed the rebase) |
|
Thank you @dcmbrs. |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 13, 2025
This PR was merged into the 6.4 branch. Discussion ---------- [Cache] Fix missing cache data in profiler | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #59838 | License | MIT There was a problem with the rebase on PR #59841 I added the fix and a test to check it Commits ------- cc505f9 [Cache] fix data collector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.