[Semaphore] skip failing tests on GitHub Actions with PHP 8.5 #59846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Feb 24, 2025
| Q | A |
|---|---|
| Branch? | 6.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | |
| License | MIT |
nicolas-grekas
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
FYI @tillkruss this skips segfaults on PHP 8.5 when Relay is used. (PR welcome to revert this PR once support is fixed)
|
Good catch, thanks @xabbuh. |
|
@nicolas-grekas We'll fix it this week 👍 |
|
We rebuilt with the latest 8.5 version but it still crashing. Might just have to consider 8.5 unstable until it's RC1. |
|
For a bit more context, it looks decidedly like an Building Relay inside the container fixes the problem and so does using a different source image. Unfortunately there is nothing obviously wrong with our 8.5 builds (e.g. warnings due to changing PHP internals). I'm still going to try and pinpoint the issue, but at the very least we'll make sure it's working/fixed when 8.5 is released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.