Skip to content

[TypeInfo] rewrite tests to not fail when self/parent are resolved at compile time #59848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2025
Merged

[TypeInfo] rewrite tests to not fail when self/parent are resolved at compile time #59848

merged 1 commit into from
Feb 25, 2025

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Feb 24, 2025 •
edited
Loading

Q A
Branch? 7.2
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

see php/php-src#17755

@carsonbot carsonbot added this to the 7.2 milestone Feb 24, 2025
@nicolas-grekas
Copy link
Member

I guess traits are still going to be runtime-resolved? Maybe that's how we can change the tests?

@xabbuh xabbuh force-pushed the type-info-tests branch 5 times, most recently from 80be151 to 68cdf10 Compare February 25, 2025 10:29
@xabbuh
Copy link
Member Author

xabbuh commented Feb 25, 2025

I guess traits are still going to be runtime-resolved? Maybe that's how we can change the tests?

I think you are right. I updated the tests to reflect the new behaviour.

@xabbuh xabbuh changed the title [TypeInfo] skip tests for features not usable with PHP 8.5 [TypeInfo] rewrite tests to not fail when self/parent are resolved at compile time Feb 25, 2025
@xabbuh xabbuh merged commit a9f661e into symfony:7.2 Feb 25, 2025
10 of 11 checks passed
@xabbuh xabbuh deleted the type-info-tests branch February 25, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

@mtarld mtarld mtarld approved these changes

Assignees
No one assigned
Labels
Status: Reviewed TypeInfo
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.
5 participants
@xabbuh @nicolas-grekas @stof @mtarld @carsonbot