Skip to content

[DoctrineBridge] add new DatePointType Doctrine type #59900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2025
Merged

[DoctrineBridge] add new DatePointType Doctrine type #59900

merged 1 commit into from
Mar 24, 2025

Conversation

garak
Copy link
Contributor

@garak garak commented Mar 3, 2025

Q A
Branch? 7.3
Bug fix? no
New feature? yes
Deprecations? no
Issues Fix #59889
License MIT

Add a new DoctrineType for the DatePoint class.
Please take a look at the issue mentioned above for more details.

@carsonbot carsonbot added this to the 7.3 milestone Mar 3, 2025
@OskarStark OskarStark changed the title add new DatePointType Doctrine type add new DatePointType Doctrine type Mar 3, 2025
@carsonbot carsonbot changed the title add new DatePointType Doctrine type [DoctrineBridge] add new DatePointType Doctrine type Mar 3, 2025
@garak
Copy link
Contributor Author

garak commented Mar 3, 2025

I can't understand the psalm failures, any help will be appreciated.
Moreover, I see that fabbot complains because I added some tests with return type, does it make sense?

@OskarStark
Copy link
Contributor

Moreover, I see that fabbot complains because I added some tests with return type, does it make sense?

Yes, we avoid the void return type in the Symfony codebase

@garak
Copy link
Contributor Author

garak commented Mar 3, 2025

I fixed the return types. The unit test failures seem unrelated.
I still need a hint about fixing the psalm inspection, thanks.

@garak garak force-pushed the datepoint-type branch 2 times, most recently from 6bc479d to 4608390 Compare March 8, 2025 17:30
@GromNaN
Copy link
Member

GromNaN commented Mar 15, 2025

Note for the DoctrineBundle integration: in addition to adding the type to the DBAL Types registry, this new type should be associated to the DatePoint property type in the typed field mapper.

nicolas-grekas
nicolas-grekas approved these changes Mar 23, 2025
View reviewed changes
@fabpot
Copy link
Member

fabpot commented Mar 24, 2025

Thank you @garak.

@fabpot fabpot merged commit 6872336 into symfony:7.3 Mar 24, 2025
3 of 7 checks passed
@fabpot fabpot mentioned this pull request Mar 24, 2025
Closed
@garak garak deleted the datepoint-type branch March 24, 2025 08:25
@wkania wkania mentioned this pull request Apr 17, 2025
Open
@wkania wkania mentioned this pull request May 1, 2025
Open
@fabpot fabpot mentioned this pull request May 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GromNaN GromNaN GromNaN left review comments

@derrabus derrabus derrabus left review comments

@xabbuh xabbuh xabbuh left review comments

@alexandre-daubois alexandre-daubois alexandre-daubois left review comments

@mtarld mtarld mtarld left review comments

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
DoctrineBridge Feature Status: Reviewed
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

[DoctrineBridge] DatePoint type
10 participants
@garak @OskarStark @GromNaN @fabpot @nicolas-grekas @derrabus @xabbuh @alexandre-daubois @mtarld @carsonbot