Skip to content

[Messenger] Reduce keepalive request noise #59908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2025
Merged

[Messenger] Reduce keepalive request noise #59908

merged 1 commit into from
Mar 4, 2025
+1 −1

Conversation

ro0NL
Copy link
Contributor

@ro0NL ro0NL commented Mar 4, 2025

Q A
Branch? 7.2
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #...
License MIT

Currently messenger:consume --keepalive creates a lot of noise (INFO log every 5 sec by default).

13:34:59 INFO      [messenger] Sending keepalive request.
13:35:04 INFO      [messenger] Sending keepalive request.

I propose to use DEBUG instead. We can also remove this log, since there's already a keepalive log per message ID:

symfony/src/Symfony/Component/Messenger/Worker.php

Lines 303 to 306 in 8b00851

$this->logger?->info('Sending keepalive request.', [
'transport' => $transportName,
'message_id' => $envelope->last(TransportMessageIdStamp::class)?->getId(),
]);

cc @HypeMC

@carsonbot carsonbot added this to the 7.2 milestone Mar 4, 2025
@alexandre-daubois
Copy link
Member

Thank you @ro0NL.

@alexandre-daubois alexandre-daubois merged commit 653e42d into symfony:7.2 Mar 4, 2025
8 of 11 checks passed
@ro0NL ro0NL deleted the patch-1 branch March 4, 2025 13:11
@fabpot fabpot mentioned this pull request Mar 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

@alexandre-daubois alexandre-daubois alexandre-daubois approved these changes

Assignees
No one assigned
Labels
Bug Messenger Status: Reviewed
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.
5 participants
@ro0NL @alexandre-daubois @fabpot @OskarStark @carsonbot