[DependencyInjection] Leverage native lazy objects for lazy services #59913
Conversation
| if (!$manager instanceof LazyLoadingInterface) { | ||
| throw new \LogicException(\sprintf('Resetting a non-lazy manager service is not supported. Declare the "%s" service as lazy.', $name)); | ||
| } | ||
| trigger_deprecation('symfony/doctrine-bridge', '7.3', 'Support for proxy-manager is deprecated.'); |
There was a problem hiding this comment.
This case should never happen (who would use proxy-manager directly instead of Symfony's lazy services for the Doctrine EM!?), still added for completeness.
There was a problem hiding this comment.
isn't this deprecation always triggered on PHP 8.3 and older ?
There was a problem hiding this comment.
it's guarded by if (!$manager instanceof LazyLoadingInterface) { (note the !) so only when ppl use proxy-manager, which we don't anymore thanks to var-exporter.
There was a problem hiding this comment.
no. This deprecation is triggered after that if, when we haven't thrown an exception (and so in the case where we will actually reset the object)
There was a problem hiding this comment.
oh, I missed that the case of lazy objects using var-exporter are handled before the check for PHP 8.4, so this is not the code path we reach in modern projects.
855b264 to
02958b9
Compare
02958b9 to
ed695a6
Compare
|
Nice! Could this PR possibly also improve performance? Any idea on how to benchmark that? |
When a service is lazy, we can leverage native lazy objects on PHP 8.4.
(Note that we still need var-exporter to generate lazy proxies when using the
proxytag - aka when proxying "by interface".)