[Routing] Add MONGODB_ID to requirement patterns
#59922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MONGODB_ID to requirement patternsMONGODB_ID to requirement patterns
There was a problem hiding this comment.
PR Overview
This PR adds a new constant, Requirement::MONGODB_ID, to support validation of MongoDB ObjectIDs in hexadecimal format. The changelog has been updated accordingly.
- Added changelog entry documenting the new constant for MongoDB ObjectID validation
Reviewed Changes
| File | Description |
|---|---|
| src/Symfony/Component/Routing/CHANGELOG.md | Updated changelog to document the addition of the new constant |
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
7a2aaaf to
44d621b
Compare
OskarStark
approved these changes
Mar 6, 2025
src/Symfony/Component/Routing/Tests/Requirement/RequirementTest.php
Outdated
Show resolved
Hide resolved
44d621b to
84085d5
Compare
mtarld
approved these changes
Mar 6, 2025
alexandre-daubois
approved these changes
Mar 6, 2025
fabpot
approved these changes
Mar 8, 2025
|
Thank you @GromNaN. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MongoDB ObjectID is a 12-bytes binary value represented as an hexadecimal string of 24 characters.
They are used by default in Doctrine MongoDB ODM.