[MonologBridge] Add ability to react to console input being interactive or not #59955
Conversation
|
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
4ef2980 to
5ac3f1d
Compare
Yes, this is expected to be 100% BC, it's opt-in for 7.x for sure, maybe it makes sense to change that for 8.x, but that's not up to me. |
5ac3f1d to
0fbbc35
Compare
|
Config part symfony/monolog-bundle#504 |
0fbbc35 to
a17b916
Compare
|
|
||
| private function isInteractiveOnlyEnabled(): bool | ||
| { | ||
| return $this->interactiveOnly && $this->input && $this->input->isInteractive(); |
There was a problem hiding this comment.
Why do we need the interactiveOnly flag? Is determining if the console is interactive via the input not enough?
There was a problem hiding this comment.
The input will always be injected, but you opt in to "interactive only" mode via config, see #58715 for an example, it would be a BC break without it.
See #58715 for example.