[HttpKernel] Only remove E_WARNING from error level during kernel init
#59975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
E_WARNING from error level during kernel initE_WARNING from error level during kernel init
nicolas-grekas
approved these changes
Mar 19, 2025
|
Thank you @fritzmg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #59139 as mentioned in #59139 (comment).
With PHP 8.4 there can currently be a huge console output spam showing the
deprecation, depending on your installed packages. This is caused by the kernel completely overriding the PHP error level within
initializeContainer(), which will cause everything to be shown (except warnings) that is triggered duringinclude.The kernel should always adhere to the
error_reportinglevel set by the environment - thus this PR fixes this issue by only removing theE_WARNINGlevel from theerror_reportinglevel when trying to silence the include failures while including the cache path during kernel init.